Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined ERROR_COPY_INTO_ITSELF #2809

Closed
applibs opened this issue Dec 29, 2018 · 6 comments
Closed

Undefined ERROR_COPY_INTO_ITSELF #2809

applibs opened this issue Dec 29, 2018 · 6 comments
Assignees

Comments

@applibs
Copy link

applibs commented Dec 29, 2018

At elFinderVolumeDrives.class.php is this line:
return $this->setError(elFinder::ERROR_COPY_INTO_ITSELF, $errpath);
but nowhere is defined: constant ERROR_COPY_INTO_ITSELF.

@nao-pon nao-pon self-assigned this Dec 29, 2018
@nao-pon
Copy link
Member

nao-pon commented Dec 29, 2018

@applibs Thanks! 👍

@applibs
Copy link
Author

applibs commented Dec 29, 2018

@nao-pon I recommend to you using best IDE phpStorm which will help you to identify many warnings and bugs. Please install PHPStorm EAP version which is free and after "Inspect code" you will see many many warnings which is good to fix it. Before Inspection is good to install some PHP plugins in PHPStorm settings. Coding with this IDE is really funny. Believe me.

@nao-pon
Copy link
Member

nao-pon commented Dec 30, 2018

@applibs I am trying the phpStorm you recommended. This is the best way to find bugs. This is a bit heavy, but I'd like to use it for coding checking. Well, I also recognized other bugs you reported, so I will fix it in a few days. Thank you!

@applibs
Copy link
Author

applibs commented Dec 30, 2018

Great. Install this Settings -> Plugins: "Php Inspections (EA Extended)", it will find many other warnings and bugs. And please be carefully, sometimes IDE wants to help fix it automatically by button(with yellow bulb) when you browse Inspector results , but some auto-fixes works bad. Soo it is good to find issues and fix it by recommendations but by hands.
For example: Inspection recommend replace == to ===, but at some situations code types are not strict and code can stop work properly., etc...
Any help in future is not problem from me. I believe that you will like it and never use other IDE.

@applibs
Copy link
Author

applibs commented Dec 31, 2018

And I forget, that you can get free license of phpStorm when you work on open source.
https://www.jetbrains.com/opensource/

@nao-pon
Copy link
Member

nao-pon commented Jan 1, 2019

@applibs Yah! I applied for use as an open source project. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants