Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong code #3278

Closed
applibs opened this issue Mar 24, 2021 · 1 comment
Closed

Wrong code #3278

applibs opened this issue Mar 24, 2021 · 1 comment
Assignees

Comments

@applibs
Copy link

applibs commented Mar 24, 2021

Loop into function public function start() in file elFinderSession.php:

this not looks nice:

if (ini_set('session.use_cookies', 0) === false) {
                    $this->fixCookieRegist === false; // <--- wrong code, what was meant by that?
                }

Also next one:
in public function __construct($opts)
is return, but return is constructor?
__construct cannot return a value

@nao-pon
Copy link
Member

nao-pon commented Jun 10, 2021

@applibs This is clearly a typo bug. I will fix this. Thank you!

@nao-pon nao-pon self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants