Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation has arbitrary minimum duration #191

Open
martinleopold opened this issue Oct 15, 2018 · 2 comments
Open

Annotation has arbitrary minimum duration #191

martinleopold opened this issue Oct 15, 2018 · 2 comments

Comments

@martinleopold
Copy link
Member

martinleopold commented Oct 15, 2018

  • Use a fresh sample project (Project > Reset)

  • Zoom-in the timeline pretty far

  • Create a new annotation on any track

  • The newly created annotation has a nominal duration of 2 sec, but a displayed length of 12 sec.

  • The annotation can't be shortened below 12 sec by dragging.

  • With a fresh sample project, then using Project > New the minimum duration seems to be 2.40 sec

Desired behaviour:

  • EDIT: Note the difference between the annotation duration (expressed as time) and the display width (expressed in px). Therese values are proportional, since the display width represents the duration, but the actual width depends on the zoom factor.
  • There is NO fixed minimum duration.
  • There IS a minimum display width of 16px.
  • This means the minimum duration that can be set in the timeline depends on the zoom level. Once the 16px width limit (and corresponding duration depending on zoom level) is hit, the annotation can be further shortened by first zooming in.
@martinleopold
Copy link
Member Author

Edited the above Issue to clarify desired behaviour. Changed min display width from 20 to 16px (to accomodate shorter annotation height).

@martinleopold
Copy link
Member Author

@dinony Is this easier to solve if we skip the minimum annotation width entirely?
So the annotation can shrink visually in width until it is basically only 1px wide – I think it shouldn't disappear completly, that would be confusing.

The thing is, a minimum annotation width intruduces problems: When the min width takes effect the annotation doesn't represent its duration accurately anymore. This has consequences for other features, like "Current annotations only". It seems to be based on visual width (?) instead of duration and thus shows annotations as "current", that are actually not active.

martinleopold added a commit that referenced this issue Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants