Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting range of annotations produces error #227

Open
martinleopold opened this issue Jun 23, 2020 · 1 comment
Open

Deleting range of annotations produces error #227

martinleopold opened this issue Jun 23, 2020 · 1 comment
Assignees

Comments

@martinleopold
Copy link
Member

Tested with: branch master (f40361e)

Shift-selecting a range of annotations and pressing the Delete Icon produces an error:

  • Reset to sample project
  • In the timeline, click on the first annotation of the first track ('MGM Title Card')
  • Shift-click on the third annotation in the same track ('Credits'). This selects the first four annotations
  • Click the delete button in the Toolbar.
  • Annotations are not deleted
  • Selection is stuck. Cannot deselect annotations or select other annotations.
  • Error in console:
core.js:6237 ERROR TypeError: Cannot read property 'filter' of undefined
    at embedAnnotations (http://localhost:4200/main.js:5844:35)
    at http://localhost:4200/main.js:7676:114
    at http://localhost:4200/vendor.js:107826:54
    at http://localhost:4200/vendor.js:105880:16
    at ArrayMapNode.push../node_modules/immutable/dist/immutable.es.js.ArrayMapNode.iterate.HashCollisionNode.iterate (http://localhost:4200/vendor.js:106278:9)
    at Map.__iterate (http://localhost:4200/vendor.js:105878:18)
    at Set.__iterate (http://localhost:4200/vendor.js:107826:22)
    at Set.forEach (http://localhost:4200/vendor.js:108212:17)
    at reducer (http://localhost:4200/main.js:7673:21)
    at combination (http://localhost:4200/vendor.js:95994:37)
@martinleopold
Copy link
Member Author

From: "adrian.soluch@gmail.com" adrian.soluch@gmail.com
Date: 4. August 2020 at 11:34:25 CEST

#227
altes issue, bereits vor meinen ersten änderungen vorhanden gewesen (checkout commit 23925a8 - letztes vor meinen ersten changes: dinony committed on 26 Feb 2019)

  • dasselbe issue existierte dort schon

core.js:1673 ERROR TypeError: Cannot read property 'filter' of undefined
at embedAnnotations (http://localhost:4200/main.js:3280:33)
at http://localhost:4200/main.js:5169:116
at http://localhost:4200/vendor.js:71833:54
at http://localhost:4200/vendor.js:69887:16
at ArrayMapNode.push../node_modules/immutable/dist/immutable.es.js.ArrayMapNode.iterate.HashCollisionNode.iterate (http://localhost:4200/vendor.js:70285:9)
at Map.__iterate (http://localhost:4200/vendor.js:69885:18)
at Set.__iterate (http://localhost:4200/vendor.js:71833:22)
at Set.forEach (http://localhost:4200/vendor.js:72219:17)
at reducer (http://localhost:4200/main.js:5166:21)
at combination (http://localhost:4200/vendor.js:60158:35)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants