[readme] Clarify execute_script option #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To protect my reputation, I will not mention how long it took before I realized
execute_script
is not a boolean option that causes JavaScript to run. Hopefully this PR clarifies the option a bit. Happy to improve the PR if my update is not completely accurate as to whatexecute_script
will accept.Thanks for your work on Grover! This is a huge improvement over our previous tool.
If you're curious, passing
true
toexecute_script
produces an error which can really lead you down a rabbit hole if you mistakenly assume it's a boolean:To make matters worse, if you add debugging statements to output the function name it's trying to run, the output is
screenshot
, nottrue
. In retrospect, I understand why this is now, and the problem is obvious. My error was probably built on a number of my own misunderstandings, and on all the context switching I've had to do lately. Hopefully this prevents others from making the same mistake I did!