-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HW-4 DataBinding 적용 #543
Merged
Merged
HW-4 DataBinding 적용 #543
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
88d6c41
HW-4 데이터바인딩 할 부분 보기 쉽게 plugin: 'kotlin-android-extensions' 제거
mtjin 3c0547c
HW-4 gradle 데이터바인딩 추가
mtjin 9155d5f
HW-4 LoginActivity 데이터바인딩 적용
mtjin d964c8b
HW-4 MovieSearch 데이터바인딩 적용
mtjin ba8c20f
HW-4 DataBindingAdapters 생성 및 구현
mtjin eb4cc40
HW-4 MovieAdapter 데이터바인딩 적용
mtjin 878b00e
HW-4 xml string resource 분리
mtjin 5d6aff2
HW-4 MovieSearch - recuclerview layoutmanager 관련 수정
mtjin 055f20d
HW-4 MovieAdapter - executePendingBindings() 추가
mtjin 88f5031
HW-4 bindingAdapter - bind prefix 제거
mtjin 1aef5d3
HW-4 DataBindingAdapter - Glide with 수정
mtjin af549d9
HW-4 DataBindingAdapter - HtmlCompact 로 수정
mtjin af06d28
HW-4 item xml bind prefix 추가
mtjin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105 changes: 58 additions & 47 deletions
105
2003/mtjin/AndroidArchitectureStudy/app/src/main/res/layout/activity_login.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,62 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
<layout xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:app="http://schemas.android.com/apk/res-auto" | ||
xmlns:tools="http://schemas.android.com/tools" | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent" | ||
android:paddingLeft="48dp" | ||
android:paddingEnd="48dp" | ||
tools:context=".ui.login.LoginActivity"> | ||
|
||
<ImageView | ||
android:id="@+id/iv_logo" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginTop="32dp" | ||
android:src="@drawable/ic_app_logo" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="parent" /> | ||
|
||
<EditText | ||
android:id="@+id/et_id" | ||
android:layout_width="match_parent" | ||
android:layout_height="0dp" | ||
android:layout_marginTop="128dp" | ||
android:hint="아이디(id)" | ||
android:inputType="text" | ||
android:padding="12dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@+id/iv_logo" /> | ||
|
||
<EditText | ||
android:id="@+id/et_pw" | ||
android:layout_width="match_parent" | ||
android:layout_height="0dp" | ||
android:layout_marginTop="16dp" | ||
android:hint="패스워드(P@sswOrd)" | ||
android:inputType="textPassword" | ||
android:padding="12dp" | ||
app:layout_constraintTop_toBottomOf="@id/et_id" /> | ||
|
||
<Button | ||
android:id="@+id/btn_login" | ||
xmlns:tools="http://schemas.android.com/tools"> | ||
|
||
<data> | ||
|
||
<variable | ||
name="login" | ||
type="com.mtjin.androidarchitecturestudy.ui.login.LoginActivity" /> | ||
</data> | ||
|
||
<androidx.constraintlayout.widget.ConstraintLayout | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:layout_marginTop="16dp" | ||
android:text="로그인" | ||
app:layout_constraintTop_toBottomOf="@id/et_pw" /> | ||
android:layout_height="match_parent" | ||
android:paddingLeft="48dp" | ||
android:paddingEnd="48dp" | ||
tools:context=".ui.login.LoginActivity"> | ||
|
||
<ImageView | ||
android:id="@+id/iv_logo" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginTop="32dp" | ||
android:src="@drawable/ic_app_logo" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="parent" /> | ||
|
||
<EditText | ||
android:id="@+id/et_id" | ||
android:layout_width="match_parent" | ||
android:layout_height="0dp" | ||
android:layout_marginTop="128dp" | ||
android:hint="아이디(id)" | ||
android:inputType="text" | ||
android:padding="12dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@+id/iv_logo" /> | ||
|
||
<EditText | ||
android:id="@+id/et_pw" | ||
android:layout_width="match_parent" | ||
android:layout_height="0dp" | ||
android:layout_marginTop="16dp" | ||
android:hint="패스워드(P@sswOrd)" | ||
android:inputType="textPassword" | ||
android:padding="12dp" | ||
app:layout_constraintTop_toBottomOf="@id/et_id" /> | ||
|
||
<Button | ||
android:id="@+id/btn_login" | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:layout_marginTop="16dp" | ||
android:onClick="@{()->login.onLoginClick()}" | ||
android:text="로그인" | ||
app:layout_constraintTop_toBottomOf="@id/et_pw" /> | ||
|
||
</androidx.constraintlayout.widget.ConstraintLayout> | ||
</androidx.constraintlayout.widget.ConstraintLayout> | ||
</layout> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LayoutManager는 xml에서 설정 할 수 있어요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5d6aff2
수정했습니다.