HW-7 Koin 적용 #580
Merged
HW-7 Koin 적용 #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangraemin
requested changes
Apr 14, 2020
Comment on lines
16
to
27
| single<MovieLocalDataSource> { MovieLocalDataSourceImpl(get()) } | ||
| single<LoginLocalDataSource> { LoginLocalDataSourceImpl(get()) } | ||
| single<PreferenceManager> { PreferenceManager(androidContext()) } | ||
| single<MovieDao> { get<MovieDatabase>().movieDao() } | ||
| single<MovieDatabase> { | ||
| Room.databaseBuilder( | ||
| androidContext(), | ||
| MovieDatabase::class.java, "Movie.db" | ||
| ) | ||
| .allowMainThreadQueries() | ||
| .build() | ||
| } |
There was a problem hiding this comment.
다른 모듈 에서도 보이는 코드인데 androidContext들을 get() 으로 바꿀 수 있을 것 같아요 ( 제가 이해한게 맞다면, startKoin에서 context를 전달받고 get()으로 전달받은 context를 사용 할 수 있는것 같아요 )
kangraemin
added
Answer Needed
mtjin
added
Review Needed
kangraemin
approved these changes
Apr 15, 2020
sjjeong
requested changes
Apr 15, 2020
Comment on lines
15
to
16
| if (BuildConfig.DEBUG) androidLogger() | ||
| else androidLogger(Level.NONE) |
sjjeong
added
Answer Needed
mtjin
added
Review Needed
sooakim
approved these changes
Apr 16, 2020
sjjeong
approved these changes
Apr 16, 2020
sjjeong
added
Merge Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factory 가 필요한데가 없어보여서 single로만 했는데 맞는지 모르겠네요.