Add an option to set the DEFLATE level. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new option, `compressionOptions`. If it contains a field `level`, it is used by the DEFLATE compression to set the compression level : 6 by default or any level between 1 (best speed) and 9 (best compression). Fix Stuk#165.
| Note : if the entry is *already* compressed (coming from a compressed zip file), | ||
| calling `generate()` with a different compression level won't update the entry. | ||
| The reason is simple : JSZip doesn't know how was compressed the content and | ||
| how to match the compression level with the implementation we use. |
There was a problem hiding this comment.
Grammar: "...doesn't know how compressed the content was and how to..."
|
Otherwise looks good 👍 |
Stuk
added a commit
that referenced
this pull request
Feb 20, 2015
Add an option to set the DEFLATE level.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new option,
compressionOptions. If it contains a fieldlevel, it is used by the DEFLATE compression to set the compression level :6 by default or any level between 1 (best speed) and 9 (best compression).
Fix #165.