Support adding files with iterators as well

[jimmywarting]

// in the zip core somewhere (simplified a lot)
function spawn(generator) {
    var iterator = generator();

    function iterate() {
        var {value, done} = iterator.next()
        !done && Promise.resolve(value).then(chunk => {
            // write chunk to entry
            iterate()
        })
    }()
}

function* generator() {
    yield chunk1
    // simulate a http range request for example
    yield new Promise(resolve => setTimeout(()=>resolve(chunk2), 1000))
    yield chunk3
    yield chunk4
}

zip.file('file.txt', generator)

so the supported data could be:
String/ArrayBuffer/Uint8Array/Buffer/Blob/Promise/Nodejs stream/generator & iterator

[jimmywarting]

Another thing why generators would be good is if you used Abstract Chunk Store

• Lets you implement your own "async-chunk-getter"

[jimmywarting]

Anything simpler just as a function that returns a promise that resolves the hole file would help reduce the memory as for how it is now. Right now node buffer is the only thing that can request more data when it needs it

Gods have for lazy loading something

// now function can return either a promise or simply `new Blob`
if(typeof data == 'function')
  Promise.resolve(data()).then(data => do something)

[dduponchel]

a function that returns a promise that resolves the hole file

I'm working on an other fix to reduce the memory usage but this one will definitively follow !

[jimmywarting]

Any progress?

[dduponchel]

Any progress?

Not yet.

[jimmywarting]

realized a while back that nodes streams are iterable. and web streams are going to be iterable too some day. That will mean you can remove all node/browser specifics hacks and just use the iterable api

if (!ReadableStream.prototype[Symbol.asyncIterator]) {
  ReadableStream.prototype[Symbol.asyncIterator] = async function* () {
    const reader = this.getReader()
    while (1) {
      const chunk = await reader.read()
      if (chunk.done) return chunk.value
      yield chunk.value
    }
  }
}

res = await fetch('something')
for await (chunk of res) {
  // {value: uint8array, done: boolean}
}

(part of my cross-js guideline for writing cross platform codes)