Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create action for generating a packaged plugin artifact #197

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

aplaice
Copy link
Collaborator

@aplaice aplaice commented Jun 25, 2023

This only applies when pushing to a tag.

The yaml files is closely based on the already existing fetch_dependencies workflow. It doesn't try to re-use the dist/ artifact generated in the fetch_dependencies workflow to avoid complexity (and because this workflow will be run only rarely, anyway).

  • Update generated UI files

  • Avoid caching pip wheels when building dist/

Otherwise, if this version of pyyaml was earlier installed (even in a different project!), then pip will use the locally generated and cached pyyaml wheel, despite the --no-binary.

Otherwise, if this version of pyyaml was earlier installed (even in a
different project!), then pip will use the locally generated and
cached pyyaml wheel, despite the `--no-binary`.
This only applies when pushing to a tag.

The yaml files is closely based on the already existing
fetch_dependencies workflow.  It doesn't try to re-use the `dist/`
artifact generated in the fetch_dependencies workflow to avoid
complexity (and because this workflow will be run only rarely,
anyway).
@aplaice aplaice merged commit 2e3cee5 into Stvad:master Jun 25, 2023
2 checks passed
@aplaice aplaice deleted the release_artifacts branch June 25, 2023 17:46
@aplaice
Copy link
Collaborator Author

aplaice commented Jun 25, 2023

For later reference, in case anybody is curious — this doesn't automatically upload the release artifact into the release corresponding to the tag, because AFAIU this requires granting the "write repository" permission to the workflow, which I'd strongly prefer to avoid doing, since that permission also allows modifying the git history (which would be problematic in case of a vulnerability in the GitHub actions/workflow system).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant