Integrate amqp-connection-manager #11
Conversation
|
|
||
| try { | ||
| this.connection = this.amqpLib.connect([this.mqURI]); | ||
| this.channel = this.connection.createChannel(); |
There was a problem hiding this comment.
Why have you moved away from confirmation channel to a regular one? Couldn't this cause a data loss?
There was a problem hiding this comment.
There was a problem hiding this comment.
This library provides different API
I am going to add waitForConnect before publish
This library provides this method
There was a problem hiding this comment.
I investigated it, so this library saves all messages to buffer and even if it is not connected we are not going to lose our data, and then when a connection is stable it uses RabbitMQ API to confirm channel inside of instance in this.channel
We don't have waitForConnect because it uses only for unit testing inside of this library
In short, this case is covered by this library
oleh-momot
force-pushed
the
feature/amqp-reconnect
branch
from
fc121b2
to
32a368d
Compare
No description provided.