Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party user who creates an issue via template that adds a label is breaking #4

Open
the-j0k3r opened this issue Oct 21, 2019 · 8 comments

Comments

@the-j0k3r
Copy link
Member

the-j0k3r commented Oct 21, 2019

  • Browser: Firefox 69.0.3 (64-bit) or any newer tested with FF 87
  • Operating System: Win 10 Pro 1803 17134.1069 or 1909
  • Link to page with the issue: any 3rd party (who is not a contributor or org member) created issues

Conditions for bug duplication:

  1. As a org/contributor for any repo you are part of, find tickets newly created issue using templates that adds a label automatically e.g. https://github.com/StylishThemes/.github/tree/master/.github/ISSUE_TEMPLATE types
  2. on said ticket add any label

You will notice that the template added label for such issues is removed when any is added by a contributor or org member.
You will notice that the template automatically added label is not checked when the list is visible, as opposed that the ones you add are checked.

further information

see #4 (comment)
and #4 (comment)

@xt0rted

issue Click on the labels and add ANY other label to this issue. You will notice that the label you added will replace and remove the bug label the issue template added.

Re: the label the template adds not being checked. Well this is weird, this issue Im opening the label is checked, so likely this is specific to other repos that use the templates, e.g that are not the this repo. Ill test that too.

Just in case this is for some reason browser specific Ive left my OS and Browser details above.

updated 27/03/2021

@the-j0k3r the-j0k3r added the bug 🐛 Something isn't working label Oct 21, 2019
@xt0rted xt0rted added the question ❔ Further information is requested label Oct 21, 2019
@the-j0k3r
Copy link
Member Author

the-j0k3r commented Oct 25, 2019

weird. Either it was fixed upstream or its something else. Will test a dif repo.

Edit: nope cant reproduce anymore both automated label not being checked in list or that adding another label magically removed the automated label.

So presuming it was fixed. cant discard it being a Firefox issue either.

@the-j0k3r the-j0k3r added the invalid ⛔ This doesn't seem right label Oct 25, 2019
@the-j0k3r
Copy link
Member Author

I think the issue is only present in certain circumstances. I seen this issue repeat elsewhere and then it was too late. Soon as I come across a ticket Ill comment on it linking to here.

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Oct 31, 2019

Here you go StylishThemes/GitHub-Dark#1021

That issue has a feature tag.

  1. The tag is not checked on the tag list
  2. if you attempt to add the duplicate tag the feature tag will be removed without any further interaction

generic

I think its only issues of ppl that dont have write privs on repo that their issues are affected by this bug, hence the issue above works as expected since I have write perms.

Ya Im not imagining things.

@the-j0k3r the-j0k3r reopened this Oct 31, 2019
@the-j0k3r
Copy link
Member Author

the-j0k3r commented Nov 7, 2019

another report you can see the issues manifest StylishThemes/GitHub-Dark#1026 this time with a feature label

Its clear only external users created issues suffer from this.

@the-j0k3r the-j0k3r added upstream bug 🌊 and removed invalid ⛔ This doesn't seem right question ❔ Further information is requested bug 🐛 Something isn't working labels Nov 7, 2019
@the-j0k3r
Copy link
Member Author

Another issue with the problem StylishThemes/GitHub-Dark#1027

@xt0rted
Copy link
Member

xt0rted commented Nov 8, 2019

I've seen a bunch of these recently, and it does seem to be every issue opened by a non org member using one of the issue templates (saw it in the wikipedia, stack overflow, and github dark repos). I wasn't able to repro the issue outside of this org though.

I reported this with all of the info I had last week. Hopefully they'll take a look and get this fixed soon since it's really annoying. I might be able to get someone to look at it sooner but @Mottie would need to invite them to the repo so they could see the edit label menu.

@the-j0k3r
Copy link
Member Author

I think you need to have write perms in the org when external users create the issue via template to be able to see issue, its cant be specific to this org only, that would be something special if it were =)

But that said YOU can invite people to GitHub Dark in any case, me no.

@xt0rted
Copy link
Member

xt0rted commented Nov 8, 2019

I don't have admin access to any of the repos except for this one since I created it.

image

@the-j0k3r the-j0k3r changed the title test issue for label being removed when adding a new label. 3rd party user who creates an issue via template that adds a label is breaking Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants