Skip to content

Commit

Permalink
Global: Fix githubusercontent document rule
Browse files Browse the repository at this point in the history 
domain() does not pick up subdomains, at least in Firefox.
  • Loading branch information
@silverwind
silverwind committed Jul 25, 2016
1 parent 0f1c53d commit 3d3409f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion github-dark.css
View file
@@ -1,4 +1,4 @@
@-moz-document regexp("^https?://((gist|guides|help|raw|status|developer)\.)?github\.com((?!generated_pages\/preview).)*$"), domain("githubusercontent.com") {
@-moz-document regexp("^https?://((gist|guides|help|raw|status|developer)\.)?github\.com((?!generated_pages\/preview).)*$"), regexp("^https?://(render|raw|gist|patch-diff)\.githubusercontent\.com\/.*") {
/*! Github Dark Theme v1.14.96 (7/24/2016) *//*
* https://github.com/StylishThemes/GitHub-Dark
* http://userstyles.org/styles/37035
Expand Down

8 comments on commit 3d3409f

@silverwind
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mottie you mentioned cloud and services subdomains. Shall we add them? Got any examples?

@Mottie
Copy link
Member

@Mottie Mottie commented on 3d3409f Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a cloud link that @un1versal sent me:

https://cloud.githubusercontent.com/assets/3521959/17084120/d4d15c34-51ad-11e6-8819-e81db621a698.PNG

He mentioned the services subdomain, but never shared a link... I figured just changing the regex to the whole domain would be better.

@silverwind
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud looks to only serve images, not sure if services exists.

@Mottie
Copy link
Member

@Mottie Mottie commented on 3d3409f Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the patch-diff link he shared as well:

https://patch-diff.githubusercontent.com/raw/kvirc/KVIrc/pull/2070.patch

So why did you switch it back to regex?

@silverwind
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the page was unstyled with domain("githubusercontent.com") in Firefox. Is it different in Chrome?

@Mottie
Copy link
Member

@Mottie Mottie commented on 3d3409f Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, I was testing it in both Chrome and Firefox this time.

@un1versal
Copy link
Contributor

@un1versal un1versal commented on 3d3409f Jul 25, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud looks to only serve images, not sure if services exists.

of course it exists.

Because the page was unstyled with domain("githubusercontent.com") in Firefox. Is it different in Chrome?

correct its broken since Mottie tuned all subdomains into regex then removed the regex due to cloud being broken, then re-added one out of the three subdomains, so two are broken. (you noticed one)

@Mottie
Copy link
Member

@Mottie Mottie commented on 3d3409f Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should all be working properly now.

Please sign in to comment.