Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw data styles? #143

Closed
Mottie opened this issue May 7, 2014 · 6 comments
Closed

Raw data styles? #143

Mottie opened this issue May 7, 2014 · 6 comments
Assignees

Comments

@Mottie
Copy link
Member

Mottie commented May 7, 2014

Github has a different server for raw data now:

https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.css

I'm not sure if we need to drop the "raw" subdomains from the url regex, but I think we will need to add support for githubusercontent.com.

As an aside, I did just learn that you can embed gists by adding a .pibb extension:

https://gist.github.com/tiimgreen/10545817.pibb

from this GitHub cheatsheet, but the style is maintained... I'm not sure people would want an embedded page to be styled.

@silverwind
Copy link
Member

Seems like the old raw URLs are all redirecting to the new domain, so this change should be safe, I'll have a look later.

> GET /StylishThemes/GitHub-Dark/master/github-dark.css HTTP/1.1
< HTTP/1.1 301 Moved Permanently
< Location: https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.css

For embedded gists, I'm a bit undecided, but leaning towards styling them to so users get consistent syntax highlighing on these.

@silverwind silverwind self-assigned this May 7, 2014
@ddavison
Copy link
Member

ddavison commented May 7, 2014

personally I don't think we should be styling raw content as it is... 😕

@silverwind
Copy link
Member

I could probably live with unstyled raw too, but on the other hand, it's nice to not have that white flash.

@silverwind
Copy link
Member

On the topic of embedded gists: I don't think we can style them unless we make the style global. And making it global would probably break the web.

@Mottie any opinion on whether to style raw? You're the tie-breaker.

@Mottie
Copy link
Member Author

Mottie commented May 8, 2014

LOL I don't really care... I'm fine either way.

@silverwind
Copy link
Member

Leaving it unstyled then. Inline gists can't be done, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants