Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides: Flow diagram #150

Closed
silverwind opened this issue Jun 20, 2014 · 8 comments
Closed

Guides: Flow diagram #150

silverwind opened this issue Jun 20, 2014 · 8 comments
Labels

Comments

@silverwind
Copy link
Member

As mentioned in #149, this (and probably other charts) needs fixes:

https://guides.github.com/introduction/flow/

@Mottie
Copy link
Member

Mottie commented Jun 21, 2014

Well, I got most of the styling. That last part "We're curious, was this helpful to you?" is an iframe. It's set to allow transparency and the body of the iframe is even set to transparent, but I can't get the background darker. I guess it wouldn't matter since the text won't be styled.

I wonder if we can apply an inverse filter on it?

@silverwind
Copy link
Member Author

Where do you see this iframe? My last part is "Merge and deploy" ending in a "ProTip".

@Mottie
Copy link
Member

Mottie commented Jun 22, 2014

It's the white block at the bottom

2014-06-22 06_31_01-understanding the github flow github guides

It's placed inside of a div with a class name of pd-embedded

@silverwind
Copy link
Member Author

Ah, now I see it. I probably just blocked the thing with NoScript on my other machine, seeing as it's not coming from a GitHub-owned domain.

Surprisingly, applying our invert rule on the iframe works for me in Firefox, but it makes the radio buttons look a bit strange. 😆

invert

@silverwind
Copy link
Member Author

Doesn't look too bad on OS X too. I'd say its an improvement over the white box. You think I should commit this?

screenshot_10

@Mottie
Copy link
Member

Mottie commented Jun 22, 2014

Go for it! I like the radio buttons hehe.

@silverwind
Copy link
Member Author

Could you verify it working in Chrome?

@Mottie
Copy link
Member

Mottie commented Jun 22, 2014

muy fantastico!

Mottie added a commit that referenced this issue Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants