highlighting are incorrect colours

[arogl]

Having updated to the latest version on userstyles, syntax highlighting is no longer working:

I use Wombat as the colour scheme, no background, Base color scheme: #4183C4, tab size of 4.

No other github styles,scripts or addons enabled.

Also the following link only shows highlighting where http has been changed to https:

https://github.com/echel0n/SickRage/commit/dbc30c43cb179196391ccc106d035057e25f72ad#diff-d41d8cd98f00b204e9800998ecf8427e

I am using FF31.0 on Win7_x64.

[Mottie]

Hmm, that is a problem (in all browsers). I've been really busy lately, so I don't recall when/if we changed any definitions for syntax highlighting.

[thinktt]

I'm pretty sure I didn't do any updates when this started happening, and I think it was working yesterday. Could it be a github change?

I rolled back to commit c739d50 from July 19th and it didn't seem to make a difference.

That's just a random commit I rolled back to but I think it would have been noticed since then.

[Mottie]

Hi @thinktt!

I think you're right, GitHub did change something... I'm seeing some new classes diff-line-code-deletion and diff-line-code-addition.

[arogl]

Motti,

Thanks for the quick fix.

Andrew.

[Poorchop]

I'm not sure if this is related to the syntax highlighting, but the line numbers are messed up, and there's also the issue of individual line highlighting. I noticed that there's already a selector for .blob-line-nums and that it uses the color #444444, but I think the line numbers used to be light against a dark background. Now it looks like the line number background follows the syntax highlighting scheme, which means that line numbers are invisible with dark themes.

Also, when clicking on a line number, the GitHub's default color is used, which conflicts with some themes, as evidenced in this picture:

Unfortunately, I don't think there's any easy solution to address this, because rules would have to be created for every color scheme, and some color schemes might not have a designated color for highlighted lines.

[Mottie]

@Poorchop Try that update... I know it works in Chrome, but didn't get a chance to test other browsers.

[Poorchop]

Works perfectly in Firefox @Mottie, thanks a lot.