Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hue-rotate .output_area img #297

Closed
sharethewisdom opened this issue Mar 21, 2016 · 10 comments
Closed

hue-rotate .output_area img #297

sharethewisdom opened this issue Mar 21, 2016 · 10 comments

Comments

@sharethewisdom
Copy link

I usually like graphs and images to retain their original color palette, particulary:

  .output_area img, .top-domains-icon[alt*="."] {
    -webkit-filter: invert(100%) hue-rotate(180deg)!important;
  }

Is it really important to match white to #181818, as stated in the comment?

@silverwind
Copy link
Member

Example?

@sharethewisdom
Copy link
Author

The linked Jupyter notebook syntax highlighting example in README.md contains a scatter plot at the bottom of the page containing the color="brown" specification in the code. Particularly, in other, more complicated graphs it could be beneficial to relate the graphical components to what's happening in the code by retaining the hue. Inverting only the brightness as I propose, does change the brown color to pink, but for me at least it is usually good enough.

@sharethewisdom
Copy link
Author

I accidentally closed this, but it's not important anyway, do let me know if you agree...

@Mottie
Copy link
Member

Mottie commented Mar 21, 2016

Hmm, what do you think of these settings?

.output_area img, .top-domains-icon[alt*="."] {
    -webkit-filter: invert(90%) hue-rotate(180deg) brightness(85%) !important;
}

It makes the blue and red a little darker.

@silverwind
Copy link
Member

Maybe tweak it a bit more so the background change isn't noticeable.

@Mottie
Copy link
Member

Mottie commented Mar 22, 2016

Go for it... I'm not sure what you mean.

@silverwind
Copy link
Member

I mean the background should still be #181818 after all the filters, I'll play with it.

@silverwind
Copy link
Member

Done in f5c1444. The background is back at #181818 with the colors being at least the original shade.

I don't think the dark blue on the first graph can be accurately represented, but I tried to give it a bit more color through saturate(200%) which seems to help. Could go further on that one, but I'm not sure it won't have unintended side effects.

@Mottie
Copy link
Member

Mottie commented Apr 8, 2016

I think these new colors turned out pretty good... check this gist out: https://gist.github.com/KirkHunter/274f90837389b882eaf3813de64dac5f

The map of LA at the bottom doesn't look too bad :P

@silverwind
Copy link
Member

The dark green shade on that graph bothers me a bit, otherwise it looks quite good, yeah :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants