Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selected text visibility on label selection menu #373

Closed
2 of 4 tasks
un1versal opened this issue Aug 3, 2016 · 3 comments
Closed
2 of 4 tasks

selected text visibility on label selection menu #373

un1versal opened this issue Aug 3, 2016 · 3 comments
Labels
bug 🐛 Something isn't working

Comments

@un1versal
Copy link
Contributor

un1versal commented Aug 3, 2016

Unstyled Content

  • No other existing issue and/or pull request.
  • URL of unstyled content.
  • If unable to provide a URL, please report the class name of unstyled content.
  • Provide steps to reproduce (opening a dialog, etc).

Steps to Duplicate

assign or unassign labels to an issue/pr when hovering over the already set labels you see selected text is too dark.

demo-a

I think class is .label-select-menu .select-menu-item.selected https://github.com/StylishThemes/GitHub-Dark/blob/master/github-dark.css#L1681-L1681

@un1versal un1versal added bug 🐛 Something isn't working and removed bug 🐛 Something isn't working labels Aug 3, 2016
un1versal added a commit to un1versal/GitHubDark-Mod that referenced this issue Aug 3, 2016
un1versal added a commit to un1versal/GitHubDark-Mod that referenced this issue Aug 3, 2016
@Mottie
Copy link
Member

Mottie commented Aug 3, 2016

Actually, GitHub doesn't add a background color when hovering over a set label... it's probably a better idea to keep it that way since the hover color interferes.

color

@silverwind
Copy link
Member

Yes, try to keep it as close as possiple to the original. I think last time I tried to fix that menu, I was unable to replicate the label-colored background on selected labels, but maybe there is a way through some invert + hue-rotate magic.

@un1versal
Copy link
Contributor Author

Yes, try to keep it as close as possiple to the original

I disagree with this principle simply because their consistency is flawed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants