Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new GitHub Repository View #264

Merged
merged 3 commits into from Nov 17, 2015
Merged

Update for new GitHub Repository View #264

merged 3 commits into from Nov 17, 2015

Conversation

mike-koch
Copy link
Contributor

As indicated at https://github.com/blog/2085-a-new-look-for-repositories, a new look for respositories is coming. Some CSS has changed for the active tab, so this PR updates the CSS to apply the necessary styles for the new CSS.

@mike-koch mike-koch mentioned this pull request Nov 17, 2015
@@ -658,7 +659,8 @@
.select-menu-button::before {
border-top-color: #eee !important;
}
.pagehead-tabs-item.selected {
.pagehead-tabs-item.selected,
.js-selected-navigation-item.selected.reponav-item {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is overqualified? Does .reponav-item.selected suffice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same applies to all additions in this PR)

@silverwind
Copy link
Member

Can you make the inactive tabs #888 instead of the link color? As these are probably a tags, you may need to do a.class to outweight our a:not() style in terms of specificity.

.js-selected-navigation-item.selected.reponav-item worked; however it was overqualified
@mike-koch
Copy link
Contributor Author

I went ahead and switched the selectors to .reponav-item.selected as it also works, and .js-selected-navigation-item.selected.reponav-item did seem overqualified. I also changed the inactive tab's text to #888 as requested. I've also included how it looks below in case you're unable to view the new design yet.

screen shot 2015-11-17 at 5 46 53 pm

@silverwind
Copy link
Member

Thanks 👍

silverwind added a commit that referenced this pull request Nov 17, 2015
Update for new GitHub Repository View
@silverwind silverwind merged commit 7706a85 into StylishThemes:master Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants