Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the header scope badge to the new github css. #299

Closed
wants to merge 1 commit into from

Conversation

rayrutjes
Copy link
Contributor

image
Instead of
image

@Mottie
Copy link
Member

Mottie commented Mar 24, 2016

I just styled this in 32f4211... I don't think its the same as your changes. Let me know what you think.

@rayrutjes
Copy link
Contributor Author

My version actually mimics the previous implementation which looked pretty neat.
image

Your version is OK as well, even-though I prefer leaving the "repository" in the same text color and make the badge right border color the same as the input border color, and avoid changing the color on active.
So short answer: I prefer mine, but feel free to keep yours ^^.

Plz note that I have only dealt with the repository search badge, I have no opinion on your other changes.

Amazing project, keep it up!

@Mottie
Copy link
Member

Mottie commented Mar 24, 2016

I'll let @silverwind or @ddavison made the deciding vote... I honestly don't mind either way

Mottie added a commit that referenced this pull request Mar 24, 2016
@Mottie
Copy link
Member

Mottie commented Mar 24, 2016

I went ahead and manually merged your PR.

Thanks!

@Mottie Mottie closed this Mar 24, 2016
@ddavison
Copy link
Member

yep good with me !

@rayrutjes rayrutjes deleted the fix/new-gh-css branch March 25, 2016 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants