Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix emoji bias #319

Merged
merged 3 commits into from May 30, 2016
Merged

fix emoji bias #319

merged 3 commits into from May 30, 2016

Conversation

SSARCandy
Copy link
Contributor

fix the bias of comment emoji reaction

before
default

after
image

@SSARCandy
Copy link
Contributor Author

test inline emoji 👍

@silverwind
Copy link
Member

Good call removing all these hacks. You can remove position: relative too which serves only to enable the positioning you removed, so the whole rules (and one comment) can be removed as well.

@SSARCandy
Copy link
Contributor Author

@silverwind I updated, plz check

@silverwind silverwind merged commit cac1e3a into StylishThemes:master May 30, 2016
@silverwind
Copy link
Member

silverwind commented May 30, 2016

Looking good, thanks!

For the record: These hacks were once necessary for perfect centering, but it appears that GitHub has now fixed the positioning issue themselves, so they are no longer needed (and where in fact interfering).

@Mottie
Copy link
Member

Mottie commented May 30, 2016

Oh, I thought we repositioned the emojis because we reduced the padding around the reaction bar since it was so tall... anyway, they still seem a bit off for me in Chrome.

Update: oops nevermind... the script wasn't using the latest update 😛

@silverwind
Copy link
Member

Could maybe move them 1px down, but I guess more research is needed:

This is on Windows, where I get a <img>:

<button class="btn-link reaction-summary-item tooltipped tooltipped-se tooltipped-multiline " name="reaction[content]" value="smile react" aria-label="SSARCandy reacted with laugh emoji">
  <g-emoji alias="smile" class="emoji mr-1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f604.png"><img alt=":smile:" title=":smile:" class="emoji" src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f604.png" height="20" width="20"></g-emoji>
  1
</button>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants