Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add https://github.com/ bottom page rss icon to orange style #348

Merged
merged 1 commit into from Jul 18, 2016
Merged

enhancement: add https://github.com/ bottom page rss icon to orange style #348

merged 1 commit into from Jul 18, 2016

Conversation

un1versal
Copy link
Contributor

This fixes consistency with other rss icon colors

Before and after

rss

@un1versal
enhancement: add https://github.com/ bottom page rss icon to orange s…
f16ff56 
…tyle

fix consistency with other rss icon colors
@Mottie Mottie merged commit eb96686 into StylishThemes:master Jul 18, 2016
@Mottie
Copy link
Member

Mottie commented Jul 18, 2016

Thanks!

Mottie added a commit that referenced this pull request Jul 18, 2016
@Mottie
Feed: use more specific selector for feed icon. See #348
7aa4ae9
@Mottie
Copy link
Member

Mottie commented Jul 18, 2016 •
edited

.mr-2 isn't specific enough... if you look at the issues page #xxx opened on XXX ## by is all orange because it also has an mr-2 class.

@silverwind
Copy link
Member

mr-2 is wrong, it just defines a margin:

.mr-2 {
    margin-right: 6px !important;
}

@un1versal
Copy link
Contributor Author

un1versal commented Jul 19, 2016 •
edited

Sorry the correct should have been

.octicon-rss.mr-2

so idk what 7aa4ae9 and e590fd0 were all about buts seems extreme changes going on

@un1versal un1versal mentioned this pull request Jul 19, 2016
Closed
un1versal referenced this pull request Jul 19, 2016
@silverwind
Frontpage: Restore explicit rss styling
64a8624
@silverwind
Copy link
Member

That margin can change anyime, better do it like we did, with a class and its parent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@un1versal @Mottie @silverwind