Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not too bright (my corneas cried for help) not too dark #358

Merged
merged 1 commit into from Jul 25, 2016

Conversation

un1versal
Copy link
Contributor

@Mottie this looks good but not so bright that it pierces corneas
in other places slightly too dark on the dull side, check it.

@Mottie
Copy link
Member

Mottie commented Jul 25, 2016

Hi @un1versal! I've already bumped up the brightness of most of the text a bit. I think going from #e2e2e2 to #f5f5f5 is too much.

Was this PR just for the placeholders?

@@ -415,7 +415,7 @@
.inline-form .btn-plain, .pr-toolbar, .diffbar, .shade-gradient,
#categories .list, .gist-banner, .select-menu-item-parent, .main-content,
.showcase-page-header, .showcase-page-pattern:after, .description-inline,
.result-group a, .border-wrap, .select-menu-item, a.feed-icon {
.result-group a, .border-wrap, .select-menu-item, a.feed-icon, session-current {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its easier if you click https://github.com/settings/security, since it is under security it contains sensitive info, mmmm
session-device session-current should be it, I think my fix was only in a dream.

this doesnt work. Ill revert.

screenshot

capture

see the background shouldnt be grey like that should be dark or transparent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silverwind c9aab5e

still needs fixing though, idk why but I cant do it

@un1versal
Copy link
Contributor Author

un1versal commented Jul 25, 2016

Hi @un1versal! I've already bumped up the brightness of most of the text a bit. I think going from #e2e2e2 to #f5f5f5 is too much.

Was this PR just for the placeholders?

Youre mixing things up... we go from #f5f5f5 and #fff to less brighter #e2e2e2

capture

remember, toke, toke, pass....

@Mottie
Copy link
Member

Mottie commented Jul 25, 2016

Can you squash these commits?

@un1versal
Copy link
Contributor Author

un1versal commented Jul 25, 2016

Can you squash these commits?

let me get a press... would you like some commit juice?

@Mottie, done monsieur

@Mottie Mottie merged commit d12a822 into StylishThemes:master Jul 25, 2016
un1versal added a commit to un1versal/GitHubDark-Mod that referenced this pull request Jul 27, 2016
imo this whole selectors bunch needs segregating selectively, else some
bits are just too dull
@un1versal un1versal mentioned this pull request Jul 27, 2016
Mottie pushed a commit that referenced this pull request Jul 27, 2016
imo this whole selectors bunch needs segregating selectively, else some
bits are just too dull
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants