Start to GitHub Material Theme #568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
silverwind
force-pushed
the
master
branch
2 times, most recently
from
751f289
to
08b4fa4
Compare
Mottie
added
themes 🖼️
enhancement ⭐
|
Any update on this theme? |
|
Complete color matching between different syntax engines is not a requirement (as it is not possible). Source files should be split in three parts, So in summary, no, this is not quite ready yet. |
the-j0k3r
referenced
this pull request
Mar 3, 2019
In default style this is.`.bg-purple` and is `!important;` so we need to manually override this.
|
No movement here since quite some time, if someone wants to continue this, raise a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #522
This is a start to the GitHub Material theme, works fine in the few languages I'd tried it in. However in others does not match at all - e.g. go between the GitHub and CodeMirror in CSS.
So this is not complete, but if anyone wants to pick it up, it should be pretty simple to complete.