Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polls: fix probot polls #617

Merged
merged 3 commits into from
May 16, 2018
Merged

polls: fix probot polls #617

merged 3 commits into from
May 16, 2018

Conversation

the-j0k3r
Copy link
Member

@the-j0k3r the-j0k3r commented May 16, 2018

polls

this should fix #616

@Mottie
Copy link
Member

Mottie commented May 16, 2018

Hi @the-j0k3r!

This change would ignore the existing poll from issue #612.

It needs to be generalized more... please modify the selector as follows:

a[href$="vote"] img[data-canonical-src*="/poll/"]

Update: and by modify, I also mean move it to the end:

  div#network.network > div > canvas,
img[data-canonical-src*="prod/timeseries/"],
img[alt="FOSSA Status"],
a[href$="vote"] img[data-canonical-src*="/poll/"] {
  filter: invert(90%) hue-rotate(180deg) !important;
}

@Mottie
Copy link
Member

Mottie commented May 16, 2018

And go ahead and add the contrast(90%), and close #615... we have too many issues/PR open for this one thing.

@the-j0k3r
Copy link
Member Author

the-j0k3r commented May 16, 2018

This change would ignore the existing poll from issue #612.

I did not see any ignoring going on, I have both + contrast all works.

Your selector makes those polls behave weirdly they are disappearing as page loads... something I dont see with my fix... -> 0b8cf1b 😊

closes #615 automatically when merged
@the-j0k3r
Copy link
Member Author

the-j0k3r commented May 16, 2018

@Mottie have another look, should autoclose everything when merged.

also added contrast but... not sure about applying that into img[alt="FOSSA Status"] it was meant for polls only.

I think all polls should go into own rule, or no? Perhaps a cleanup for another pr?

good to go
@the-j0k3r
Copy link
Member Author

sorry for noise, should be good to go, merge and all shall be auto closed/fixed #616 #615

@Mottie Mottie merged commit cbc2f98 into StylishThemes:master May 16, 2018
@Mottie
Copy link
Member

Mottie commented May 16, 2018

Awesome thanks!

@the-j0k3r
Copy link
Member Author

@Mottie I think we should separate the poll selectors into their own group so they are all together and the contrast setting doesnt affect something its not meant to.

@Mottie
Copy link
Member

Mottie commented May 16, 2018

Naw, it's fine... the FOSSA status actually looks a bit better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some polls are not inverted even after 8f18587
2 participants