Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the representation of arbitrary JSON for input/results #66

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

chendrix
Copy link
Collaborator

No description provided.

Copy link
Member

@charlesdaniels charlesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris and I discussed this previously. We decided that although both an empty schema ({}) or this "oneOf" method could work in that they should be equivalent for valid inputs, there is a possibility that the oneOf style would push some type errors closer to where they happen, e.g. if someone tries to pass a function in as input. That should cause an error up front this way, where otherwise it might instead throw a more obscure error during ser/de or get all the way to OPA and then fail.

@srenatus srenatus merged commit 4ec264a into main Mar 12, 2024
@srenatus srenatus deleted the chendrix/fix-arbitrary-json-representation branch March 12, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants