refactor: one rule, one file #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having all rules lumped into a single file only per category got to be a bit messy eventually. This change uses one file per rule, making it easier to both find and to work with rules in isolation — hopefully making it easier to contribute new ones too. There is still a few things I would like to fix, like having unit tests actually be unit tests, and not as it currently stands that they test an input against *all* rules in the category... but this change is big enough as it is, so I'm deferring that to a future PR. Fixes #144 Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having all rules lumped into a single file only per category got to be a bit messy eventually. This change uses one file per rule, making it easier to both find and to work with rules in isolation — hopefully making it easier to contribute new ones too.
There is still a few things I would like to fix, like having unit tests actually be unit tests, and not as it currently stands that they test an input against all rules in the category... but this change is big enough as it is, so I'm deferring that to a future PR.
Fixes #144