Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-breakable-word-threshold option to line-length rule #350

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add non-breakable-word-threshold option to line-length rule #350

merged 1 commit into from
Sep 28, 2023

Conversation

anderseknert
Copy link
Member

Fixes #327

@anderseknert
Add non-breakable-word-threshold option to line-length rule
bbcc44f 
Fixes #327

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert
Copy link
Member Author

@iamleot let me know what you think 😊

@iamleot
Copy link
Contributor

iamleot commented Sep 27, 2023 •
edited
Loading

Hello Anders,
I've just tested it and it works perfectly!

Thank you very much!

@anderseknert
Copy link
Member Author

Awesome @iamleot 😃 Will make it into the next release.

charlieegan3
charlieegan3 reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice addition 😎

@anderseknert anderseknert merged commit 41e127d into main Sep 28, 2023
1 check passed
@anderseknert anderseknert deleted the non-breakable-words branch September 28, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlieegan3 charlieegan3 charlieegan3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anderseknert @iamleot @charlieegan3