Add --profile option to regal lint
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
profiling
branch
from
c2c8f21
to
ffe4da2
Compare
This sets a profiler on eval in each goroutine, and then accumulates the result from each into a final report. At this point we're only including this in the JSON output format (similar to `--metrics`) but we'll want to support this for each format some time later. Fixes #334 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
profiling
branch
from
ffe4da2
to
01b36fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets a profiler on eval in each goroutine, and then accumulates the result from each into a final report. At this point we're only including this in the JSON output format (similar to
--metrics) but we'll want to support this for each format some time later.Fixes #334
{ "violations": [], "summary": { "files_scanned": 98, "files_failed": 0, "files_skipped": 0, "num_violations": 0 }, "profile": [ { "location": "/regal/ast.rego:278", "total_time_ns": 1329484096, "num_eval": 4, "num_redo": 27214, "num_gen_expr": 4 }, { "location": "/regal/config/config.rego:90", "total_time_ns": 1122320502, "num_eval": 176, "num_redo": 88, "num_gen_expr": 4 }, { "location": "/regal/ast.rego:218", "total_time_ns": 984304114, "num_eval": 130766, "num_redo": 66674, "num_gen_expr": 6 }, { "location": "/regal/main.rego:69", "total_time_ns": 795476410, "num_eval": 252, "num_redo": 84, "num_gen_expr": 6 }, { "location": "/regal/config/config.rego:39", "total_time_ns": 792559582, "num_eval": 88, "num_redo": 0, "num_gen_expr": 2 }, { "location": "/regal/ast.rego:307", "total_time_ns": 726335912, "num_eval": 140, "num_redo": 102, "num_gen_expr": 4 }, { "location": "/regal/main.rego:46", "total_time_ns": 648658586, "num_eval": 84, "num_redo": 0, "num_gen_expr": 2 }, { "location": "/regal/main.rego:44", "total_time_ns": 576676664, "num_eval": 252, "num_redo": 84, "num_gen_expr": 6 }, { "location": "/regal/rules/testing/metasyntactic_variable.rego:48", "total_time_ns": 530986756, "num_eval": 16, "num_redo": 24, "num_gen_expr": 4 }, { "location": "/regal/config/config.rego:17", "total_time_ns": 526488250, "num_eval": 8, "num_redo": 8, "num_gen_expr": 8 } ] }