Fix: prefer-some-in-iteration false positive iteration in fn args
#579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meh, checking back at that code snippet from #528 and this did in fact not solve that 😒 Keep digging, I guess, but this is an improvement nonetheless. |
charlieegan3
approved these changes
Feb 26, 2024
anderseknert
force-pushed
the
new-some-in-fp
branch
from
12dde5e
to
148fdcd
Compare
This fixes one of the errors reported in #528 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
new-some-in-fp
branch
from
148fdcd
to
fd766cd
Compare
|
Fixed so now it does fix the some .. in false positive as reported in the above mentioned issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the errors reported in #528