report: Fix profile count aggregation #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
commented
May 8, 2024
| profCopy.NumEval += entry.NumEval | ||
| profCopy.NumRedo += entry.NumRedo | ||
| profCopy.NumGenExpr += entry.NumGenExpr | ||
| profCopy.TotalTimeNs += entry.TotalTimeNs | ||
| profCopy.Location = entry.Location |
There was a problem hiding this comment.
This didn't seem required.
AddProfileEntries was creating a copy from the supplied update rather than the global store of counts. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
force-pushed
the
fix-profiling-counting
branch
from
bdf1f9d
to
3a59070
Compare
|
cloc is now closer to 10.5k The numbers I see now are closer to that ~12626 rather than jumping up and down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddProfileEntries was creating a copy from the supplied update rather than the global store of counts.
Fixes #457