Rule: trailing-default-rule
#716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
approved these changes
May 14, 2024
| rule["default"] == true | ||
|
|
||
| name := ast.ref_to_string(rule.head.ref) | ||
| name in all_names(array.slice(input.rules, 0, i)) |
There was a problem hiding this comment.
🤔 how should I read this? if the default rule is in the 0-ith range of rules? Perhaps it's too early, but it's not clear to me how this is working 😅
There was a problem hiding this comment.
array.slice(input.rules, 0, i)
provides a slice of all the rules up until i, i.e the default rule.. and then we check if the same name of the default has been used for any of those.
There was a problem hiding this comment.
Ahh, yes. that does make sense. I'd assumed that the implementation was going to be like: make sure that the rule is the first when ordered by line or similar, but this works too! thanks.
Simple rule to check that `default` rules are placed before non-default rules. Fixes #699 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
default-first
branch
from
5416653
to
af95710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple rule to check that
defaultrules are placed before non-default rules.Fixes #699