Add import shadowing rule #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken from OPA strict mode - we should have it too Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
approved these changes
Apr 11, 2023
|
|
||
| some i, identifier in _identifiers | ||
|
|
||
| identifier in array.slice(_identifiers, 0, i) |
There was a problem hiding this comment.
This is clever! I think it's generally the later imports which are the issue. However, for the sake of argument. Which line is the issue here?
import data.bar as foo
import data.foo
I'd make a case for line 1, not line 2 personally. But that might just be my take 🙂. Mostly playing devil's advocate here... not a blocker.
There was a problem hiding this comment.
I'd say it's still the later line — that's the one shadowing the first, alias or not :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from OPA strict mode - we should have it too