Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second response serializaton #22

Merged

Conversation

paymog
Copy link

@paymog paymog commented Dec 6, 2019

Remove the second response serialization because it breaks custom
response payload handlers. Fixes #10

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         249    245    -4     
  Branches       26     26           
=====================================
- Hits          249    245    -4
Flag Coverage Δ
#codecov 100% <100%> (ø) ⬆️
#dj111 100% <100%> (ø) ⬆️
#dj20 100% <100%> (ø) ⬆️
#dj21 100% <100%> (ø) ⬆️
#dj22 100% <100%> (ø) ⬆️
#drf310 100% <100%> (ø) ⬆️
#drf37 100% <100%> (ø) ⬆️
#drf38 100% <100%> (ø) ⬆️
#drf39 100% <100%> (ø) ⬆️
#py27 100% <100%> (ø) ⬆️
#py34 100% <100%> (ø) ⬆️
#py35 100% <100%> (ø) ⬆️
#py36 100% <100%> (ø) ⬆️
#py37 100% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/rest_framework_jwt/utils.py 100% <100%> (ø) ⬆️
src/rest_framework_jwt/views.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbf262...a4a922e. Read the comment docs.

@fitodic
Copy link
Collaborator

fitodic commented Dec 13, 2019

Thanks for the contribution! Could you please rename 22.bug.md to 22.bugfix.md as described in the changelog guidelines?

Remove the second response serialization because it breaks custom
response payload handlers. Fixes Styria-Digital#10
@paymog paymog force-pushed the remove.second.response.serializaton branch from bcd0f10 to a4a922e Compare December 13, 2019 08:42
@fitodic fitodic merged commit 6f1313c into Styria-Digital:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom JWT_RESPONSE_PAYLOAD_HANDLER negated by second call to view serializer
3 participants