-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow refreshing a blacklisted token #37
Disallow refreshing a blacklisted token #37
Conversation
Otherwise, you can refresh a blacklisted token and get a fresh token that works.
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
- Coverage 98.13% 97.94% -0.2%
=========================================
Files 19 19
Lines 430 437 +7
Branches 32 34 +2
=========================================
+ Hits 422 428 +6
Misses 6 6
- Partials 2 3 +1
Continue to review full report at Codecov.
|
Love the PR! Could you please add a changelog? As soon as that's added, we'll push a patch release. |
Will do. Sorry to forget that. |
Once the patch release is out, I was thinking it may be worth requesting a CVE and ensuring that people scanning for vulnerable versions are warned about 1.15.0. Please let me know if you have any thoughts about that. |
No worries, most people do, including myself 🙂
Sounds great! Unfortunately, I no longer have write access to this repository so I won't be able to merge this change. I'm sure someone from @Styria-Digital/owners will pick this up. |
@fitodic sorry for the inconvenience. We've lower your rights to plain member and with that accidentally removed your maintainer rights for this repo. You have been now declared as an outside collaborator and explicitly given maintaining rights for this repository. Let me know if you have any difficulties with merging PR. Thank you for your efforts! |
@ntuckovic Thanks for the info and the maintainer access! I understand and completely agree with the change in membership status to a regular group member. @ashokdelphia I'll merge this and release a patch version soon. |
Thank you! |
1.15.1 is uploaded to PyPI. |
Otherwise, you can refresh a blacklisted token and get a fresh token that works.
Fixes #36.