-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for nerfstudio #98
Conversation
I simply tested the difference between ’cam_dirs‘ and ’directions‘ on the garden scene. Each method trained two models based on nerfstudio, and the psnr difference of the validation set was within 0.1. |
|
|
Hi,when I start training, it appears to be |
I mentioned this situation in README.md:
Fastest Solution
|
Excuse me, I followed the above method, but I ran into an unsolvable problem when executing |
Hi @Pioneer6gun9! Someone reminded me that the rounding strategy of mipnerf360 is not ceil but round. I've updated the code above. Btw, I've submit a pull request for nerfstudio for this issue. |
This comment was marked as resolved.
This comment was marked as resolved.
I modify the codes here, and resolve the problem:
to
|
Hi @unanan, you're right. Now that the PR submitted to nerfstudio about rounding mode has been merged. I will submit a PR to update the readme of this repo later. |
@Jing1Ling Hello mate, Do you have any solutions to resolve this issue?:
The entire error info is:
|
Hi @s1eeveW ! 'segment_coo‘ is a function in pytorch_scatter package. You can install pytorch_scatter in your python envirionment. Also, you can simply comment these lines and use this line to calculate 'loss_hash_decay'. They only have little difference and I think the replacement won't effect much thing. |
According to the template provided by nerfstudio, several related files have been added.
• 'zipnerf_config.py': parameters configuration.
• 'zipnerf_model.py': use a model wrapper to reuse the Model class in 'internal/models.py'.
Replace 'cam_dirs' with 'directions' as dicussed in this issue.
You can use some tools provided by nerfstudio (e.g. viewer) with this patch. Except for the modification of cast_ray(), the original content will not be affected. This is also because camera directions are not provided in Nerfstudio's input data which named RayBundle.