Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<i> and <b> tags creating a break #9

Closed
zemiguelll opened this issue Aug 17, 2018 · 9 comments
Closed

<i> and <b> tags creating a break #9

zemiguelll opened this issue Aug 17, 2018 · 9 comments
Assignees
Milestone

Comments

@zemiguelll
Copy link

@zemiguelll zemiguelll commented Aug 17, 2018

When using < i > and < b > tags the change on the text is not being made inline, a new line is being created.
From your example:
< p >Lorem ipsum < b >dolor< /b > sit amet.< /p >
becomes:
Lorem ipsum
dolor
sit amet.

Also, when adding only fontSize to the TextStyle the bold or italic changes to white (adding "color: Colors.black" fixes it, but it would be good to keep a consistent default color).

@Sub6Resources

This comment has been minimized.

Copy link
Owner

@Sub6Resources Sub6Resources commented Aug 17, 2018

Ah, yup. That's a big issue. Thanks for reporting that. I built this relatively quickly and recently, so we're still working out a couple major bugs.

I'm aware of the text color issue, but if you wouldn't mind opening a new issue with that issue that would be great to help keep things organized.

@zemiguelll

This comment has been minimized.

Copy link
Author

@zemiguelll zemiguelll commented Aug 20, 2018

Hi @Sub6Resources, first of all thank you for all the work put into this plugin!
Thanks for the quick reply, I will open a ticket for the other issue.

@Sub6Resources

This comment has been minimized.

Copy link
Owner

@Sub6Resources Sub6Resources commented Aug 22, 2018

@zemiguelll I'm in the middle of a major refactor that will fix this issue and several others. It will be released as 0.5.0 in the next couple days after I work out a couple issues with the refactor.

@why2mf

This comment has been minimized.

Copy link

@why2mf why2mf commented Aug 23, 2018

Thanks for woking.I need it too

@Sub6Resources

This comment has been minimized.

Copy link
Owner

@Sub6Resources Sub6Resources commented Aug 24, 2018

This has just been fixed in 0.5.0.

@chusmf

This comment has been minimized.

Copy link

@chusmf chusmf commented Aug 27, 2018

I have ^0.5.3 version and I still have the same problem

@Sub6Resources

This comment has been minimized.

Copy link
Owner

@Sub6Resources Sub6Resources commented Aug 27, 2018

@chusmf

This comment has been minimized.

Copy link

@chusmf chusmf commented Aug 28, 2018

It happens when the sentence occupies more than 1 line in the space.

In the next example, the two first p tags are ok, the third one breaks in two lines

Html(
          data: """     
          <div>       
            <p>You <b>cannot </b> install a nonexistent product!</p>
            <p>You <b>cannot install </b>  a nonexistent product!</p>
            <p>You <b>cannot install </b> a nonexistent product from that shop!</p>          
          </div>
          """,  
          padding: EdgeInsets.all(8.0),
          backgroundColor: Colors.lightGreen);
@Sub6Resources

This comment has been minimized.

Copy link
Owner

@Sub6Resources Sub6Resources commented Aug 31, 2018

Hmm, this looks like slightly different than the original issue @chusmf. I've opened a new issue: #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.