Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom text alignment #112

Merged

Conversation

GeertJohan
Copy link
Contributor

Fixes #69

Example usage:

foo = Html(
...
  customTextAlign: (dom.Node node) {
    if (node is dom.Element) {
      switch (node.localName) {
        case "p":
          return TextAlign.justify;
      }
    }
  },
...
);

@Sub6Resources Sub6Resources self-requested a review June 17, 2019 22:10
@Sub6Resources Sub6Resources self-assigned this Jun 17, 2019
@Sub6Resources Sub6Resources added bugfix Fixes a bug in the package high-priority labels Jun 17, 2019
@Sub6Resources
Copy link
Owner

Thanks for the pull request! At first glance this looks like it will work fine. I'll complete the actual review later today and work on merging and releasing within the next couple days.

@Sub6Resources Sub6Resources added this to the Next Version milestone Jun 18, 2019
@GeertJohan
Copy link
Contributor Author

GeertJohan commented Jun 19, 2019

Hi @Sub6Resources, is there anything else I can do to get this merged? Thanks!

@Sub6Resources Sub6Resources merged commit 97a671b into Sub6Resources:master Jun 20, 2019
@Sub6Resources
Copy link
Owner

Nope, I've got it covered. Thanks though! The release should be available on Pub within the next couple hours.

@GeertJohan
Copy link
Contributor Author

Thanks @Sub6Resources !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug in the package high-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can justify text
2 participants