Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 #122

Merged
merged 69 commits into from
May 11, 2020
Merged

Version 1.0.0 #122

merged 69 commits into from
May 11, 2020

Conversation

Sub6Resources
Copy link
Owner

@Sub6Resources Sub6Resources commented Jul 11, 2019

This pull request contains all the changes that are coming for version 1.0.0 by the end of December. There are some drastic API changes. Changes from this branch while the pr is in WIP will be released as prerelease versions on pub occasionally once they are stable enough.

See the new https://github.com/Sub6Resources/flutter_html/blob/new-parser/PRE_CHANGELOG.md for a short list of changes in this version.

These are the issues this pull request currently resolves (there are more in progress):
Fixes #14
Fixes #18
Fixes #55
Fixes #64
Fixes #105
Fixes #106
Fixes #107
Fixes #108
Fixes #121
Fixes #123
Fixes #126
Fixes #127
Fixes #128
Fixes #141
Fixes #147
Fixes #158
Fixes #163
Fixes #173
Fixes #175
Fixes #184
Fixes #186
Fixes #194
Fixes #275

Here's my list of TODOs before 1.0.0 is released (roughly in order of when they will happen):

  • Add video support
  • Add iframe support
  • Add svg support
  • Add audio support
  • Add support for customRender
  • Reimplement support for ul/ol
  • Fix issues with white space and doubled margins
  • Reimplement support for table
  • Reimplement onImageError/onImageTap
  • Re-add support for shrinkWrap/shrinkToFit property
  • Update documentation for prerelease
  • Release 1.0.0-pre.1
  • Add support for style tag.
  • Add support for inline styles.
  • Release 1.0.0-pre.2
  • Write comprehensive unit and golden tests
  • Update documentation
  • Write examples
  • Create screenshots
  • Release 1.0.0

@hunglv21
Copy link

Version 1.0.0-pre.1 has been published! The rest of the release process for 1.0.0 is outlined in the checklist above. All of the current issue fixes are included in version 1.0.0-pre.1.

Thanks bro!

@mnshaikna
Copy link

mnshaikna commented Jan 7, 2020

When is 1.0.0 getting released?
the pre version gives me some error with <video>

@Sub6Resources
Copy link
Owner Author

Sub6Resources commented Jan 8, 2020

@mnshaikna 1.0.0 is set to be released very soon. Can you specify what errors you are receiving (preferably by opening a new issue)?

@JEuler
Copy link
Contributor

JEuler commented Feb 11, 2020

Hi! Very useful library! Any news on 1.0.0 release? Using pre and all is okay, but anyway :)

@lucien144
Copy link

Is there anything I can do to help push this forward? :)

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files           8        8           
  Lines         900      900           
=======================================
  Hits          729      729           
  Misses        171      171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1686b19...1686b19. Read the comment docs.

@ryan-berger ryan-berger changed the title [WIP] Version 1.0.0 Version 1.0.0 May 11, 2020
Copy link
Collaborator

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment