Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16 CSOM assembly seems to miss ComposedLookItemLinkModelHandler #832

Closed
SubPointSupport opened this issue May 10, 2016 · 1 comment
Closed

Comments

@SubPointSupport
Copy link
Contributor

SubPointSupport commented May 10, 2016

As per the comments:

"It works with SPMeta2.CSOM.Foundation but not with SPMeta2.CSOM.Foundation-v16
both nuGet packages add an assembly named SPMeta2.CSOM.dll to the project. The SPMeta2.CSOM.Foundation one seems to override the other (-v16)"


var model = SPMeta2Model.NewWebModel(web =>
{
web.AddComposedLookItemLink(new ComposedLookItemLinkDefinition
{
ComposedLookItemName = "..."
});
});
service.DeployWebModel(context, model);

"Value cannot be null.\r\nParameter name: Can't find model handler for type:[SPMeta2.Definitions.ComposedLookItemLinkDefinition]. Current ModelService type: [SPMeta2.CSOM.Standard.Services.StandardCSOMProvisionService]."

https://www.yammer.com/spmeta2feedback/#/Threads/show?threadId=701403699

*.csproj have incorrect build conditions for O365 due to the last v12/v13 build change.

'$(spRuntime)'=='15' Or '$(spRuntime)'=='16' or  '$(Configuration)'=='Debug'

That should include '365' as a spRuntime version as well. The following should be done:

  • [DONE] There should be a "baseline stat" file containing the amount of defs and handlers per runtime. The file is to be edited manually, by devs, per release
  • [DONE] Build process should also produce a "stat" file and compare with the "baseline"
  • [DONE] NuGet packaging should check assemblies as per the "baseline" to ensure the right assemblies are added to the nuGet packages
  • [DOME] build should fail if some conditions in the *.csproj files were excluded (handlers aren't there or def aren't there as expected)
  • [DONE] NuGet packaging process should check assemblies under lib35/lib40/lib45 and ensure that the libraries are really built with the correct .NET framework version
@SubPointSupport SubPointSupport self-assigned this May 10, 2016
@SubPointSupport SubPointSupport added this to the 2016.05.16 milestone May 10, 2016
@SubPointSupport SubPointSupport modified the milestones: 2016.05.16, 2016.05.30 May 26, 2016
@SubPointSupport
Copy link
Contributor Author

*.csproj have incorrect build conditions for O365 due to the last v12/v13 build change.

'$(spRuntime)'=='15' Or '$(spRuntime)'=='16' or  '$(Configuration)'=='Debug'

That should include '365' as a spRuntime version as well. The following should be done:

  • There should be a "baseline stat" file containing the amount of defs and handlers per runtime. The file is to be edited manually, by devs, per release
  • Build process should also produce a "stat" file and compare with the "baseline"
  • NuGet packaging should check assemblies as per the "baseline" to ensure the right assemblies are added to the nuGet packages

SubPointSupport added a commit that referenced this issue Jun 27, 2016
+ gate checking on assembly build for sp10, 13, 16 and O365
SubPointSupport added a commit that referenced this issue Jun 28, 2016
[DONE] Build process should also produce a "stat" file and compare with the "baseline"

Baseline check rewritten in PS + Mono.Cecil. Built-in reflection loads up assembly and dependencies making it imposible to work with different assembly versions and dependencies on multiple SharePoint API runtimes. Including .NET 45+ analysis.
SubPointSupport added a commit that referenced this issue Jun 28, 2016
+ NuGet packaging should check assemblies as per the "baseline" to ensure the right assemblies are added to the nuGet packages
SubPointSupport added a commit that referenced this issue Jun 28, 2016
+ v16 CSOM assembly seems to miss ComposedLookItemLinkModelHandler #832
+ [TESTING] build should fail if some conditions in the *.csproj files were excluded (handlers aren't there or def aren't there as expected)
SubPointSupport added a commit that referenced this issue Jun 28, 2016
+ v16 CSOM assembly seems to miss ComposedLookItemLinkModelHandler #832
+[TESTING] build should fail if some conditions in the *.csproj files were excluded (handlers aren't there or def aren't there as expected)
SubPointSupport added a commit that referenced this issue Jun 29, 2016
+ [DONE] NuGet packaging process should check assemblies under lib35/lib40/lib45 and ensure that the libraries are really built with the correct .NET framework version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant