default to .eslintignore, allow overrides

[ratherblue]

This fixes #144 and #127 .

It defaults to the first .eslintignore it finds, but also allows the path overridden to be set with --ignore-path in the args array (See Inline Overrides documentation

See also SublimeLinter's config_file documentation

Tested it locally and seems to be working nicely.

[ratherblue]

Actually this doesn't fix the relative path issue completely. Closing to find better fix.

[ratherblue]

Going to re-open because it fixes the issue for people who have ESLint 2.5.0 and under. Need a separate fix for the issue introduced by eslint/eslint#5694

[peterkrieg]

@ratherblue : do you happen to know if there is a fix for this with ESLint 2.5.0 +? (I'm running ESLint 3.1.1)

[ratherblue]

@peterkrieg No... unfortunately it's an issue (feature?) with ESLint. Basically if you have ./src/foo.js in .eslintignore but then you run eslint from the src directory, foo.js will no longer be ignored because it's technically ignoring ./src/src/foo.js.

As far as I can tell, unless ESLint adds a command line option for cwd (there is one in the CLIEngine already), the only way to fix it would be if this plugin can somehow execute eslint from a different folder. (And I'm not sure how to make it do that)

[peterkrieg]

@ratherblue Thanks a lot for explanation, that's what I was afraid of. I wish I knew where to even start to try to fix the ESLint problem and submit a PR.. I'd really love this fixed hahah!

[ratherblue]

@peterkrieg I opened an issue with ESLint (eslint/eslint#6759). Hopefully they add a way for us to fix it.

[ratherblue]

@peterkrieg it looks like the ESLint contributors are going to look into the --ignore-path relative pathing issue.

[peterkrieg]

@ratherblue thanks a lot for update! I've been following along and your issue sure has created a lot of discussion. Great news!

[kaste]

This plugin has new maintainers. What's the status here? Is it correct that this has been fixed generally with Eslint 4.x?

Would it help if we set the cwd/chdir to the project root path before starting eslint? 👋

[kaste]

This is not compatible with SL4 anymore. In SL4 we set the working dir to the project folder, so generally this should work better by default, right now. Otherwise, anybody can set this using the args setting.