Pretend ' ' for empty views #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint < 4.10.0 has a bug where it shows its CLI usage info when we send the empty string via stdin. The solution here is to send one space instead. Tested with the 'no-trailing-spaces' rule to not mark as an error for such cases. Proper version branching is maybe over-engineering, and left as exercise for the reader. Another solution would be to just check the configuration bc empty views usually cannot have lint errors. This *could* be done via `eslint --print-config .`
|
Refixes #230 |
|
Would be really nice to run this hack only on eslint < 4.10.0? |
|
Yeah, sure we need SublimeLinter/SublimeLinter#1335 first. Then some idea to cache the result of the version call. Or we need to check and parse the semver from packages.json |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint < 4.10.0 has a bug where it shows its CLI usage info when
we send the empty string via stdin. The solution here is to send
one space instead.
Tested with the 'no-trailing-spaces' rule to not mark as an error
for such cases.
Proper version branching is maybe over-engineering, and left as
exercise for the reader.
Another solution would be to just check the configuration bc empty
views usually cannot have lint errors. This could be done via
eslint --print-config .