Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error/warning colours #165

Closed
dankini opened this issue Dec 9, 2014 · 8 comments
Closed

Error/warning colours #165

dankini opened this issue Dec 9, 2014 · 8 comments
Labels

Comments

@dankini
Copy link

dankini commented Dec 9, 2014

Hi, wonder if someone can enlighten me with a strange issue.
ST3 v3059
SublimeLinter v3.4.24

Have noticed when I open exact same file the text highlighting code colours are a lottery. They seem to change indiscriminently between yellow and red. No apparent reason, no apparent pattern to it.

Best illustrated with two images of same simple bit of code:
First, error codes correctly highlighted in red
st3red
Second, error codes incorrectly highlighted in yellow
st3yellow
Another example showing incorrect colouring
st3yellow2

At one point I thought a pattern was emerging whereby if I opened by double-clicking file from system it showed errors as yellow but if I opened from within ST (File>Open File...) it correctly showed errors in red. But that doesn't seem to be the case now and it just seems to be random.

Can confirm relevant user settings as:
"error_color": "D02000"
"warning_color": "DDB700"

Have removed sublimelinter package and reinstalled but no joy.

Any ideas please?

@NotSqrt
Copy link
Member

NotSqrt commented Dec 9, 2014

Probably because multiple linters return similar linting problems, but without the same level error/warning ?

I see that you have pyflakes and flake8..

@dankini
Copy link
Author

dankini commented Dec 9, 2014

Indeed I do and have always had them without noticing this before yesterday. I installed both as this was recommended on some blogs.

If this is the cause is there a general recommendation of one over the other? Does one more accurately classify errors/warnings than the other?

Thanks for the reply.

@NotSqrt
Copy link
Member

NotSqrt commented Dec 9, 2014

flake8 = pyflakes + pep8

I noticed on my projects that flake8 does not report all pep8 errors, so I tend to use all the available linters, even if they are redondant (pylint, pyflakes, pep8, ..).

I correct the errors immediately on all my code so I never notice that the color changes 😄

@dankini
Copy link
Author

dankini commented Dec 9, 2014

Guess I stick with my set up and tolerate inconsistent line highlighting between linters. Although it will play havoc with my OCD!!

Thanks NotSqrt

@dankini
Copy link
Author

dankini commented Dec 9, 2014

Ps although ...

... it's the difference in gutter icon colour and line highlighting colour that really bugs me. Not only does it bug me but it strikes me as incorrect since I am using the default 'colourised' gutter theme so colours should match, no?

@NotSqrt
Copy link
Member

NotSqrt commented Dec 9, 2014

The gutter and line highlighting updates and the linters themselves are asynchronous, so if the linters finish around the same time, the result is not predictable. The last one wins.

@dankini
Copy link
Author

dankini commented Dec 9, 2014

OK, understood.
Maybe I make error and warning colours in user settings the same and let the guttering signify the type. If only so visually consistent.

@braver
Copy link
Member

braver commented Sep 22, 2017

I don't think overlapping linters like this, where they agree on what's wrong but not on the severity level, is very common or something we want to really support.

@braver braver closed this as completed Sep 22, 2017
@braver braver added the wontfix label Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants