Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"SublimeLinter: Report (Open Files)" lines number are wrong #78

Closed
bizoo opened this issue Feb 20, 2014 · 0 comments
Closed

"SublimeLinter: Report (Open Files)" lines number are wrong #78

bizoo opened this issue Feb 20, 2014 · 0 comments

Comments

@bizoo
Copy link
Contributor

bizoo commented Feb 20, 2014

Sorry doesn't have time for a Pull Requests.

The report generated by this command are all lines number off by 1 (one line before the actual line, eg. 2240 instead of 2241).

There's probably a missing +1 in the code.
Compare:

class SublimelinterShowAllErrors(sublime_plugin.TextCommand):
...
options.append(['{}  {}'.format(lineno + 1, message), code])

with:

class SublimelinterReportCommand(sublime_plugin.WindowCommand):
...
out += '    {:>{width}}: {}\n'.format(line, message, width=width)
@bizoo bizoo closed this as completed Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant