Remove completion restrictions #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #107 Suggest properties also within `meta.selector` as this is the most likely scope in front of a nested selector, if a property is not yet terminated by semi-colon.
|
I wonder how annoying this would be, to get property suggestions in every single selector you're trying to write? I'll play with it a bit. |
|
You do get more useful suggestions this way. You can now just type On the other hand does feel a bit weird in situations where you're obviously not trying to type a property: 
|
|
As there's no way to distinguish incomplete property assignments from selectors, there's no other way. With this change behaviour would at least be equal to LSP-css and VSCode. |
|
I agree, it’s a clear overall improvement. And it’s not like it’s masking any useful suggestions for selectors, because we don’t actually have any of those.
|
braver
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107
Suggest properties also within
meta.selectoras this is the most likely scope in front of a nested selector, if a property is not yet terminated by semi-colon.