Two empty lines at EOF with ensure_newline_at_eof_on_save and trim_trailing_white_space_on_save enabled

[inta]

Summary

Given the cursor is on the last line of the file and there is white space before the cursor. When I save the file the white space is removed, but there is also a new empty line added. So after saving there are two empty lines at the end of the file.

Expected behavior

• white space gets removed
• there is one empty line at the end of the file

Actual behavior

• white space gets removed
• empty line is appended
• there are two empty lines at the end of the file

Steps to reproduce

1. set ensure_newline_at_eof_on_save to true
2. set trim_trailing_white_space_on_save to true
3. go to the end of any file
4. enter some white space (space or tab)
5. save the file

Environment

• Operating system and version:
  • Linux: Debian 9 Stretch (testing)
• Monitor:
  • Resolution 1920x1200
  • dpi_scale no idea where to check it, but it is not set in settings
• Sublime Text:
  • Build 3126
  • 64 bit

This issue is reproducible in reverted/clean state.

[keith-hall]

Also confirmed on Windows (7 with ST 3136 x64).

[keith-hall]

possible duplicate of #263

[FichteFoll]

Looks like a duplicate to me.

[inta]

Yes, I think it is a duplicate. I did not find the other issue by searching for "ensure_newline_at_eof_on_save", sorry.

[FichteFoll]

Closing as a duplicate of #263.

Actually, I consider this issue to be more precise so I'm closing the other issue instead.

[keith-hall]

this may have been fixed in 3189, as the functionality has been moved from a Python module to core. I can't replicate it any more.

[FichteFoll]

Can confirm I am not observing this issue anymore. 🎉

See #2600.