Calling Ctrl+K, Ctrl+D to skip item, does not skip the item and selects wrong items

[evandrocoan]

Originally posted on:

1. https://forum.sublimetext.com/t/find-under-expand-skip-unexpected-behaviour/33852

Summary

Calling Ctrl+K, Ctrl+D to skip item, does not skip the item and selects wrong items

Expected behavior

test 1
|test| 2
|test| 3
|test| 4

Actual behavior

|test| 1
|test| 2
|test| 3
test 4

Steps to reproduce

1. Create a view with:

   test 1
   test 2
   test 3
   test 4
   

2. Put the cursor/caret on the start of the line test 3
3. Press Ctrl+D (find_under_expand) 3 times
4. Press Ctrl+K, Ctrl+D

Environment

• Operating system and version:
  • Windows 10 build 15063 x64
  • Mac OS ...
  • Linux ...
• Monitor:
  • Resolution 1920x1080
  • dpi_scale used in ST 1.0
• Sublime Text:
  • Build 3156
  • 32 bit

[FichteFoll]

Via #42, this bug has existed since ST2. I closed that issue as a duplicate because this one has more detailed reproduction steps.

Basically, quick_skip_next always thinks the current search is the lowest selected region, which goes terribly wrong if you wrapped around the end of the file. Because this behavior is so unexpected, I consider it to be major because it may cause you to remove/edit lines you didn't actually intend to by modifiying the selections in an unexpected way.

[BenjaminSchaaf]

Fixed in build 4080.

[gwenzek]

I'm seeing this bug in 4098 on Mac. Am I the only one impacted ?

[FichteFoll]

I cannot reproduce with the steps given in OP on Linux.

[deathaxe]

Works on Windows, too.

[BenjaminSchaaf]

@gwenzek Can't reproduce with 4098 on macOS.

[gwenzek]

I made a screen cast of the bug in --safe-mode, just to be sure we are talking about the same thing (and that I'm not crazy)
Please let me know if I can help debugging this further.

I'm on MacOS 10.15.7 in case it might help.

subl_expand_bug.mp4

[FichteFoll]

Hm, that definitely seems like a related problem, although it's not what was initially reported here. I'll leave this for @BenjaminSchaaf.

[BenjaminSchaaf]

I've made a new issue for that here: #3986