Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling `Ctrl+K, Ctrl+D` to skip item, does not skip the item and selects wrong items #2091

Open
evandrocoan opened this issue Dec 8, 2017 · 1 comment

Comments

@evandrocoan
Copy link

commented Dec 8, 2017

Originally posted on:

  1. https://forum.sublimetext.com/t/find-under-expand-skip-unexpected-behaviour/33852

Summary

Calling Ctrl+K, Ctrl+D to skip item, does not skip the item and selects wrong items

Expected behavior

test 1
|test| 2
|test| 3
|test| 4

Actual behavior

|test| 1
|test| 2
|test| 3
test 4

Steps to reproduce

  1. Create a view with:
    test 1
    test 2
    test 3
    test 4
    
  2. Put the cursor/caret on the start of the line test 3
  3. Press Ctrl+D (find_under_expand) 3 times
  4. Press Ctrl+K, Ctrl+D

Environment

  • Operating system and version:
    • Windows 10 build 15063 x64
    • Mac OS ...
    • Linux ...
  • Monitor:
    • Resolution 1920x1080
    • dpi_scale used in ST 1.0
  • Sublime Text:
    • Build 3156
    • 32 bit
@FichteFoll

This comment has been minimized.

Copy link
Member

commented Dec 11, 2017

Via #42, this bug has existed since ST2. I closed that issue as a duplicate because this one has more detailed reproduction steps.

Basically, quick_skip_next always thinks the current search is the lowest selected region, which goes terribly wrong if you wrapped around the end of the file. Because this behavior is so unexpected, I consider it to be major because it may cause you to remove/edit lines you didn't actually intend to by modifiying the selections in an unexpected way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.