Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutter icons overlap on certain settings #2441

Closed
deathaxe opened this issue Oct 13, 2018 · 1 comment
Closed

Gutter icons overlap on certain settings #2441

deathaxe opened this issue Oct 13, 2018 · 1 comment

Comments

@deathaxe
Copy link
Collaborator

Summary

This is a more or less partial forward of the issue jisaacks/GitGutter#522 (comment).

If the horizontal space of a line drops below a certain value of 16 logical pixels, GitGutter adds small triangle icons in the gutter area to represent a deleted hunk. Two icons are used to achieve that - themes/Default/deleted_bottom@2x.png at line 76 and themes/Default/deleted_top@2x.png at line 77.

As per documentation the icon size of the @2x.png files is 32x32 pixels.

Expected behavior

Gutter icons should be scaled and positioned correctly to not exceed the actual line height in order to prevent them from overlapping.

image

Actual behavior

The gutter icons seem to be scaled and or placed incorrectly, which makes them overlapping.

image

The following screen capture shows that it even might be a positioning error only. See how the gutter icons change, if the caret moves along the lines.

animation

Steps to reproduce

  1. Open a file within a git repository with ST3 and GitGutter installed
  2. Add the following settings from below to Preferences.sublime-settings
  3. Delete a line in the open file and have a look onto the gutter.
	"font_face": "Fira Code",
	"font_options":
	[
		"dwrite_cleartype_classic"
	],
	"font_size": 8,
	"line_padding_bottom": 0,
	"line_padding_top": 0,
	"ui_scale": 1.8,

Environment

  • Operating system and version:
    • Windows 10
    • MacOS (OS with Retina display by original issue reporter)
  • Monitor:
    • Resolution 1920x1200
    • ui_scale used in ST >=1.8
  • Sublime Text:
    • Build 3176
    • 64 bit
@wbond wbond added this to the Build 3190 milestone Feb 7, 2019
@wbond
Copy link
Member

wbond commented Feb 19, 2019

This is fixed in build 3190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants