Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Revert "Bump xlsx2csv from 0.8.1 to 0.8.2 (#10155)" #10165

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

MasterOdin
Copy link
Member

@MasterOdin MasterOdin commented Feb 6, 2024

This reverts commit c81f5e2.

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant
  • Screenshots are attached to Github PR if visual/UI changes were made

What is the current behavior?

The xlsx2csv@0.8.2 only provides a source distribution which fails to install on Ubuntu 22.04 with the version of pip that comes from python3-pip:

    ubuntu-22.04: Collecting xlsx2csv==0.8.2
    ubuntu-22.04:   Downloading xlsx2csv-0.8.2.tar.gz (227 kB)
    ubuntu-22.04:      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 227.1/227.1 KB 18.4 MB/s eta 0:00:00
    ubuntu-22.04:   Installing build dependencies: started
    ubuntu-22.04:   Installing build dependencies: finished with status 'done'
    ubuntu-22.04:   Getting requirements to build wheel: started
    ubuntu-22.04:   Getting requirements to build wheel: finished with status 'done'
    ubuntu-22.04:   Preparing metadata (pyproject.toml): started
    ubuntu-22.04:   Preparing metadata (pyproject.toml): finished with status 'done'
    ubuntu-22.04:   WARNING: Generating metadata for package xlsx2csv produced metadata for project name unknown. Fix your #egg=xlsx2csv fragments.
    ubuntu-22.04: Discarding https://files.pythonhosted.org/packages/c9/d1/70613896bd07a49cfb19312838b8ffb29232e6be5c8e381b953473468e5b/xlsx2csv-0.8.2.tar.gz#sha256=cdd272c82f8b32f1cee76aeaef87b2ee3549661fddf90f7ecf2310967a16fc84 (from https://pypi.org/simple/xlsx2csv/): Requested unknown from https://files.pythonhosted.org/packages/c9/d1/70613896bd07a49cfb19312838b8ffb29232e6be5c8e381b953473468e5b/xlsx2csv-0.8.2.tar.gz#sha256=cdd272c82f8b32f1cee76aeaef87b2ee3549661fddf90f7ecf2310967a16fc84 (from -r /usr/local/submitty/GIT_CHECKOUT/Submitty/.setup/pip/system_requirements.txt (line 25)) has inconsistent name: filename has 'xlsx2csv', but metadata has 'unknown'
    ubuntu-22.04: ERROR: Could not find a version that satisfies the requirement xlsx2csv==0.8.2 (from versions: 0.6, 0.6.1, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.7.5, 0.7.6, 0.7.7, 0.7.8, 0.8.0, 0.8.1, 0.8.2)
    ubuntu-22.04: ERROR: No matching distribution found for xlsx2csv==0.8.2

xlsx2csv@0.8.2 is the first version in the last bunch that does not provide a .whl build, and so requires a newer version of pip to be installed for now, though ideally upstream could provide a whl and that'd allow us to upgrade (dilshod/xlsx2csv#276).

What is the new behavior?

Reverted to xlsx2csv@0.8.1. Our usage of this module is pretty basic, and the bugfixes included in the latest version don't really affect us, so there's no need to force our upgrade to 0.8.2 at the moment.

Other information?

Vagrant up should succeed: https://github.com/Submitty/Submitty/actions/runs/7800496541

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f02f00) 22.79% compared to head (4e967e1) 22.41%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #10165      +/-   ##
============================================
- Coverage     22.79%   22.41%   -0.38%     
  Complexity     8352     8352              
============================================
  Files           228      211      -17     
  Lines         29907    27763    -2144     
  Branches         75       75              
============================================
- Hits           6817     6224     -593     
+ Misses        23018    21467    -1551     
  Partials         72       72              
Flag Coverage Δ
autograder ?
js 27.09% <ø> (ø)
migrator 100.00% <ø> (ø)
php 19.71% <ø> (ø)
python_submitty_utils ?
submitty_daemon_jobs 91.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MasterOdin MasterOdin merged commit 70893ef into main Feb 6, 2024
18 checks passed
@MasterOdin MasterOdin deleted the chore-xlsx2csv-revert branch February 6, 2024 16:32
charvimehradu added a commit to charvimehradu/Submitty that referenced this pull request Mar 15, 2024
charvimehradu added a commit to charvimehradu/Submitty that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant