Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX:Developer] Black history month duck #10169

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

ziesski
Copy link
Member

@ziesski ziesski commented Feb 8, 2024

Screen Shot 2024-02-08 at 1 52 51 AM

To embrace and welcome all community, we are adding black history month duck.
The design is the three common theme color of black history month.
It will be visible randomly during entire february.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (70893ef) 22.79% compared to head (696595c) 22.79%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #10169      +/-   ##
============================================
- Coverage     22.79%   22.79%   -0.01%     
  Complexity     8352     8352              
============================================
  Files           228      228              
  Lines         29907    29909       +2     
  Branches         75       75              
============================================
  Hits           6817     6817              
- Misses        23018    23020       +2     
  Partials         72       72              
Flag Coverage Δ
autograder 21.92% <ø> (ø)
js 27.09% <ø> (ø)
migrator 100.00% <ø> (ø)
php 19.71% <0.00%> (-0.01%) ⬇️
python_submitty_utils 71.65% <ø> (ø)
submitty_daemon_jobs 91.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@RayReyRam RayReyRam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this code with every log in, and the ducks appearance is correct through out. I've also went into different categories and the ducks appearance is also updated. The code changed looks good and clean , as well as commented with the type of duck style it is. These code is ready to merge

Copy link
Contributor

@JoJo-ESC JoJo-ESC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duck looks good ready to merge!

@ryvaru ryvaru self-requested a review February 16, 2024 15:07
@bmcutler bmcutler merged commit 19a1ed6 into main Feb 16, 2024
18 checks passed
@bmcutler bmcutler deleted the black-history-duck branch February 16, 2024 18:28
@ryvaru ryvaru removed their request for review February 16, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants